-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reshape #20
Fix reshape #20
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 74.21% 77.32% +3.10%
==========================================
Files 11 12 +1
Lines 256 269 +13
==========================================
+ Hits 190 208 +18
+ Misses 66 61 -5 ☔ View full report in Codecov by Sentry. |
…s of neural network parameters or other expressions.
NOTE: This pr is set to "draft" until JuliaSymbolics/SymbolicUtils.jl#644 is fixed. |
The issue mentioned above JuliaSymbolics/SymbolicUtils.jl#644 still hasn't been fixed since JuliaSymbolics/SymbolicUtils.jl#679 has not been merged. I will solve that problem for now by introducing the slight type piracy via: function Symbolics.SymbolicUtils.Code.create_array(::Type{<:Base.ReshapedArray{T, N, P}}, S, nd::Val, d::Val, elems...) where {T, N, P}
Symbolics.SymbolicUtils.Code.create_array(P, S, nd, d, elems...)
end |
Renamed file (typo).
Fixes #19
Fixes #18
Introduces a keyword argument
reduce
that specifies which operation should be used to performmapreduce
inbuild_nn_function
(and similar functions).But introduces type pyracy! Maybe Fixes #18 should be fixed by doing a pr in
SymbolicUtils
.