Apply proper syntax to triple-quoted cmds #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to apply any syntax to the contents of the 'c' literal.
non-Jedi
force-pushed
the
triple-quote-cmd
branch
from
ed66581 to
8630eee
Compare
Previously they were being syntax-propertized as 3 single-quoted cmds.
non-Jedi
force-pushed
the
triple-quote-cmd
branch
from
8630eee to
796ddfd
Compare
tpapp
approved these changes
Jul 15, 2020
|
@giordano @FelipeLema @rfourquet if any of you has time, please review this, I would like to merge. |
giordano
approved these changes
Jul 16, 2020
|
Yes, I just resolved that manually (I am surprised that @non-Jedi: as always, thanks for the excellent work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary cleanup before #132 could be attempted and should also make triple-backticks work correctly which has never been true before.
This also appears to have fixed all the corner-cases with escapes in strings.
Closes #15, closes #119