Skip to content

pass directory to command instead of cd #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2021
Merged

pass directory to command instead of cd #43

merged 1 commit into from
Mar 21, 2021

Conversation

ericphanson
Copy link
Member

This addresses a thread-safety issue #42 (comment)

@ericphanson ericphanson requested a review from giordano March 21, 2021 20:15
giordano
giordano approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I was really struggling to understand why we'd end up into a deleted directory, I wasn't looking into this file at all 😂

@ericphanson ericphanson merged commit 98a9ccf into main Mar 21, 2021
@ericphanson ericphanson deleted the eph/fix-cd branch March 21, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericphanson @giordano