Skip to content

Conversation

@inkydragon
Copy link

@inkydragon inkydragon commented Mar 29, 2023

Fix #2073

  • Do we want to update the version of Ubuntu? Maybe use ubuntu:latest
  • Do we need a tectonic docker image? juliadocs/documenter-tectonic
    And rename texlive-based image to: juliadocs/documenter-texlive
    Estimated size is 100MB~. And current image is 430MB+
  • And I'd like to rename the docker usename to juliadocs

todo

  • run PDF build for JuliaDocs/Documenter.jl
  • run PDF build for JuliaLang/julia
  • release docker image, and update DOCKER_IMAGE_TAG in src/latex/LaTeXWriter.jl

Note:

  • I choose MIT OR CC0-1.0 for Dockerfile, Because I think it makes it easy for people to copy and paste

Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need the fonts, like in the old image?

We also had ENV DEBIAN_FRONTEND noninteractive. I am not 100% sure why though. Maybe @fredrikekre remembers?

Comment on lines +7 to +23
RUN set -eux; \
apt-get update; \
apt-get install --no-install-recommends -y \
# minimal texlive
texlive-luatex \
texlive-latex-base \
texlive-latex-recommended \
texlive-latex-extra \
# latexmk: LaTeX build tool
latexmk \
# code highlighting
python-pygments \
# refresh the font cache
fontconfig \
; \
rm -rf /var/lib/apt/lists/*; \
apt-get purge -y --auto-remove;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure bikeshed, but I think Docker supports heredocs, which should allow us to get rid of the \s?

# SPDX-License-Identifier: MIT OR CC0-1.0
# build image:
# docker build -t juliadocs/documenter-latex:1.0 .
FROM ubuntu:18.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's update this. Could be conservative and use 22.04 though.

@mortenpi
Copy link
Member

mortenpi commented Apr 1, 2023

Do we need a tectonic docker image? juliadocs/documenter-tectonic. And rename texlive-based image to: juliadocs/documenter-texlive. Estimated size is 100MB~. And current image is 430MB+

Tectonic should be used via a JLL I think, so shouldn't be necessary to have an image?

And I'd like to rename the docker usename to juliadocs

Sounds reasonable.

  • I choose MIT OR CC0-1.0 for Dockerfile, Because I think it makes it easy for people to copy and paste

Fine by be. I feel that it's not particularly copyrightable anyway, for what it's worth. So CC0 seems suitable.

@mortenpi
Copy link
Member

mortenpi commented Apr 1, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate LaTeX Docker image to GCHR

2 participants