Fix datetime conversion bug #560
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
+ Coverage 69.80% 69.87% +0.07%
==========================================
Files 14 14
Lines 2113 2118 +5
==========================================
+ Hits 1475 1480 +5
Misses 638 638
🚀 New features to boost your workflow:
|
felixcremer
reviewed
Nov 3, 2025
| tsteps = try | ||
| timedecode(ar[:], aratts["units"], lowercase(get(aratts, "calendar", "standard"))) | ||
| dec = timedecode(ar[:], aratts["units"], lowercase(get(aratts, "calendar", "standard")), prefer_datetime=false) | ||
| round_datetime.(dec) |
There was a problem hiding this comment.
This is breaking because it changes the output type to a DateTime. This function should only be called when the prefer_datetime keyword is true.
This is also the cause of the doc build failure.
Suggested change
| round_datetime.(dec) | |
| prefer_datetime && round_datetime.(dec) |
There was a problem hiding this comment.
unfortunately,
failed to run `@example` block in docs/src/UserGuide/select.md:45-49
│ ```@example subset
│ using CFTime
│ time1 = DateTime360Day(2001,01,16)
│ tos[time = At(time1)]
│ ```
│ exception =
│ promotion of types CFTime.DateTime360Day{CFTime.Period{Int64, Val{1}(), Val{-3}()}, Val{(1900, 1, 1)}()} and DateTime failed to change any arguments
│ Stacktrace:
│ [1] error(::String, ::String, ::String)
There was a problem hiding this comment.
Is this with my suggestions?
There was a problem hiding this comment.
Ahh, sorry is still a suggestion! Not merged yet. Sorry, my bad 😞. We need to apply the suggestion to see the effect then.
meggart
commented
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug similar to the one described by @felixcremer in rafaqz/Rasters.jl#1000 by rounding to the closest millisecond before converting time stamps to DateTime.