- 
                Notifications
    You must be signed in to change notification settings 
- Fork 23
[Draft] Add CF conventions in YAXArray to use in plots #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage   73.67%   73.81%   +0.14%     
==========================================
  Files          12       12              
  Lines        1865     1875      +10     
==========================================
+ Hits         1374     1384      +10     
  Misses        491      491              
 🚀 New features to boost your workflow:
 | 
| BUG in scatter plot but not inb lines plot: No method matching project_position(,..., DiskArrays.BlockedIndices) required for Makie.plot in unidata example.nc. | 
| From the docs failures it seems as if this broke somehow the AlgebraOfGraphics functionality. | 
| AlgebraOfGraphics creates a DimStack using the name for its type. I changed the name function to always return a Symbol. | 
| 
 | 
| AoG errors might be unrelated to this PR, probably more an internal AoG change, I will take a look later. | 
…rays.jl into use_cf_conventions_in_plot * 'use_cf_conventions_in_plot' of github.com:danlooo/YAXArrays.jl: Fix cf label test Fix error AlgebraOfGraphics use symbol
| DimensionalData v0.29.16 + is required to show colorbar label. However, YAXArrays allows below as DD 0.27. | 
| mmm ..    | 
| Whats is the status for this PR. Is is ready for a final review or still in draft stage? | 
This PR aims to utilize CF conventions to generate name and label of a YAXArray.
Enables to use CF meta data in heatmap plots, see rafaqz/DimensionalData.jl#989.
Implements same behavior as of python xarray.
Like named DimArrays, this will also add the name to
Base.show, if the CF metadata if present:Closing #393 would improve the axis labels.
plot(a_cfa)See testset
"YAXArrays with CF conventions"for further details.