Fix tests and deprecations on Julia 0.6 #1146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add compatibility with pre-contrasts ModelFrame constructor
…ise for speed improvement (#1070)
Completely remove support for DataArrays.
This depends on PRs moving these into NullableArrays.jl. Also use isequal() instead of ==, as the latter is in Base and unlikely to change its semantics.
groupby() did not follow the order of levels, and wasn't robust to reordering levels. Add tests for corner cases.
Use the fallbacks for now, should be added back after JuliaData/CategoricalArrays.jl#12 is fixed.
Not sure what I meant by this. If it was really serious, we'll discover it sooner or later.
This is a much more general issue (JuliaStats/NullableArrays.jl#85) which can be tackled later.
For now, preserve the current semantics: conversion to NullableArray does not happen via insert!().
Again a broader issue which doesn't particularly affect DataFrames. Cf. JuliaStats/NullableArrays.jl#143
Better handle that separately.
Shorter written that way for now. Filed as JuliaStats/NullableArrays.jl#144.
This depends on a CategoricalArrays change by which levels are sorted when creating the array.
There's no inconsistency here: when the input is a Matrix, there's no point in returning a NullableArray. Anyway, these are test methods.
We don't have to handle this right now.
Keep this in DataFrames for now, renaming it to the more explicit sharepools(). Also relax signatures to accept non-Nullable categorical arrays.
These were not exercized by the tests, and the use case for them isn't obvious. (They were formerly methods of DataArrays.PooledDataArray().)
For NullableArrays, even current git master is not enough at this time.
Tests pass, but the Nullable{Any} results could be annoying for users.
New type merging NominalArray and OrdinalArray in 0.0.5.
These shouldn't live in DataFrames.
Misc minor enhancements
Also return a NullableCategoricalArray from sharepools() since the code currently doesn't check that no null values are present. anyway this function is internal and the change imposes no overhead.
* Better display of Nullables * Don't write trailing space in Latex output Also fix missing newline in show test
* limit attribute of IOContext is used for html generation * fixup
I apparently missed these occurrences when removing these functions.
The instruction to rename columns if they don't match was part of the docs previously (http://dataframesjl.readthedocs.io/en/latest/joins_and_indexing.html). I adapted the syntax to avoid using {}.
nalimilan
force-pushed
the
nl/deprecations
branch
from
9863b27 to
326b53b
Compare
|
Tests passed on 0.5 on Travis, AppVeyor is stuck for several days. Good to merge? |
|
What about 0.6? |
|
I'm not sure, but it looks like there's an issue in CategoricalArrays. |
|
I confirm it's in CategoricalArrays. That's a stack overflow probably related to the recent type system changes. EDIT: looks like it's JuliaLang/julia#20103 (comment) |
|
Superseded by #1164. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on a new version of Compat being tagged (JuliaLang/Compat.jl#306).
The slightly weird syntax for
!works around the unfortunate combination of JuliaLang/julia#20037 and JuliaLang/julia#20039.@kleinschmidt The same trick will likely be needed for StatsModels.