Respect xml:space="preserve" (#43) #45
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported in #43. I've added extra tests, too.
One caveat in testing: I had to change one test (only):
I had to change the condition from
===
to only==
. With this single change, tests now all pass locally.I've also checked that this PR works well with XLSX.jl downstream and all XLSX tests also pass locally.
With this PR, XLSX now properly reads a workbook like this:

which has leading and trailing whitespace in column A and, in column B, only has whitespace.
Reading this XLSX file now works correctly:
Previously, leading and trailing spaces would be trimmed, and cells containing only whitespace would become
missing
.I'm afraid I can't match the simple elegance of your coding style, though!