Skip to content

Commit

Permalink
fix for 1.6.7. bump version. remove depwarn for collectrows
Browse files Browse the repository at this point in the history
  • Loading branch information
joshday committed Jul 24, 2023
1 parent 791fc11 commit b41f424
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "PlotlyLight"
uuid = "ca7969ec-10b3-423e-8d99-40f33abb42bf"
authors = ["joshday <[email protected]>"]
version = "0.7.2"
version = "0.7.3"

[deps]
Artifacts = "56f22d72-fd6d-98f1-02f0-08ddc0907c33"
Expand Down
5 changes: 0 additions & 5 deletions src/PlotlyLight.jl
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,6 @@ function Base.show(io::IO, M::MIME"text/html", o::Plot; setting::Settings = DEFA
end

#-----------------------------------------------------------------------------# utils
function collectrows(x::AbstractMatrix)
Base.depwarn("collectrows is deprecated. PlotlyLight now automatically applies this to matrices", :collectrows; force=true)
collect.(eachrow(x))
end

fix_matrix(x::Config) = Config(k => fix_matrix(v) for (k,v) in pairs(x))
fix_matrix(x) = x
fix_matrix(x::AbstractMatrix) = collect.(eachrow(x))
Expand Down
2 changes: 0 additions & 2 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,4 @@ end
#-----------------------------------------------------------------------------# other
@testset "other" begin
@test occursin("{}", repr("text/html", PlotlyLight.page(Plot())))

@test_warn "deprecated" PlotlyLight.collectrows(rand(2,2))
end

2 comments on commit b41f424

@joshday
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/88220

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.7.3 -m "<description of version>" b41f4248f6dd63f330e26b4e62393d439d674aa2
git push origin v0.7.3

Please sign in to comment.