Skip to content

test: winworkstation - don't check for 'default' option name specifically #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

krynju
Copy link
Member

@krynju krynju commented Jun 25, 2025

In 6.10 the image option name comes from the image tag if no display name is set and now it's usually "anytag" instead of "default".
This doesn't matter too much. What matters is the option type (base-cpu/base-gpu). The display name is purely visual and shouldn't be tested against

@krynju krynju force-pushed the kr/2025-06-25-6y39hc branch from 61d6418 to bae44b3 Compare June 25, 2025 12:27
@krynju krynju requested a review from mortenpi June 25, 2025 12:29
@mortenpi mortenpi changed the title fix(tests): winworkstation - don't check for 'default' option name specifically test: winworkstation - don't check for 'default' option name specifically Jun 25, 2025
@mortenpi
Copy link
Member

This LGTM if the CI passes. Right now it's failing due to an expired token. Also, I took the liberty to remove the CHANGELOG entry, since it's neither a fix or a feature, and doesn't require a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants