Adds ODEs for structure growth. Makes WCDM and LCDM initialization more uniform. #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have taken the liberty to add some functionality by providing a function to compute the growth factor and its first and second derivatives. So far I have not been able to redefine the Cosmology structures so that they allow for a cache in order to avoid re-solving the ODE in each call like fastpm does, for example. I have added tests for this part in the test suite.
I have also modified the Cosmology structures so they are all defined as the WCDM were, within the loop. I think this makes development much easier. Moreover, I made the structures able to accept kwargs instead and changed the relevant parameters for the definition of a cosmology. In particular, OmegaR, and OmegaM are now derived from OmegaC, OmegaB, Neff and T_cmb. Nonetheless, I have left OmegaM and OmegaR kewords in the
cosmology
function so the tests are still compatible.Please feel free to check and modify as you please and merge if you find these modifications useful :). Also don;t hesitate to write back if there are any questions.
Thanks!