sort: avoid use of ReverseOrdering for BitonicSort
#860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We reverse the order as part of the bitonic sort algorithm, but `ReverseOrdering` is not the true reverse order for an order `::Perm`. This led to non-stable sorting for `sortperm`. Fixed by hand-wiring the reversal. Fixes JuliaArrays#858.
stev47
force-pushed
the
fix/sortperm-stable
branch
from
93a5a41 to
59a924d
Compare
|
I'm not sure why |
|
Total coverage decreased because after this patch there is fewer covered lines (you've removed two lines that were considered as covered), nothing to worry about. There are no new non-covered lines. |
|
Can we merge this and tag 1.0.3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reverse the order as part of the bitonic sort algorithm, but
ReverseOrderingis not the true reverse order for an order::Perm.This led to non-stable sorting for
sortperm.Fixed by hand-wiring the reversal.
Fixes #858.