stage: v1 wip #623
stage: v1 wip #623
Conversation
Summary of ChangesHello @abhishekg999, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request marks a significant step towards a more structured and extensible API for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant amount of work towards a new v1 SDK, including a new API client generator, data models, and an OpenTelemetry-based tracing system. The overall structure is well-designed, using factories and clear separation of concerns. My review focuses on the new v1 implementation, where I've identified a couple of high-severity bugs related to caching and argument inspection in the tracer, along with some medium-severity style suggestions for the new API generator script to improve maintainability.
| def _format_inputs( | ||
| self, f: Callable[..., Any], args: Tuple[Any, ...], kwargs: Dict[str, Any] | ||
| ) -> Dict[str, Any]: | ||
| try: | ||
| params = list(inspect.signature(f).parameters.values()) | ||
| inputs: Dict[str, Any] = {} | ||
| arg_i = 0 | ||
| for param in params: | ||
| if param.kind == inspect.Parameter.POSITIONAL_OR_KEYWORD: | ||
| if arg_i < len(args): | ||
| inputs[param.name] = args[arg_i] | ||
| arg_i += 1 | ||
| elif param.name in kwargs: | ||
| inputs[param.name] = kwargs[param.name] | ||
| elif param.kind == inspect.Parameter.VAR_POSITIONAL: | ||
| inputs[param.name] = args[arg_i:] | ||
| arg_i = len(args) | ||
| elif param.kind == inspect.Parameter.VAR_KEYWORD: | ||
| inputs[param.name] = kwargs | ||
| return inputs | ||
| except Exception: | ||
| return {} |
There was a problem hiding this comment.
The current implementation of _format_inputs is complex and has a bug where it includes self in the captured arguments for instance methods. You can simplify this significantly and make it more robust by using inspect.signature().bind(). This will correctly handle all argument passing styles and allow you to easily remove self or cls from the result.
def _format_inputs(
self, f: Callable[..., Any], args: Tuple[Any, ...], kwargs: Dict[str, Any]
) -> Dict[str, Any]:
try:
bound_args = inspect.signature(f).bind(*args, **kwargs)
bound_args.apply_defaults()
arguments = bound_args.arguments
if "self" in arguments:
del arguments["self"]
if "cls" in arguments:
del arguments["cls"]
return arguments
except Exception:
return {}|
|
||
|
|
||
| def filter_schemas() -> Dict[str, Any]: | ||
| from typing import Generator |
There was a problem hiding this comment.
This local import of Generator can be moved to the top of the file (line 7) with the other imports from the typing module. This improves code readability and follows standard Python style guidelines.
| check=True, | ||
| ) | ||
| finally: | ||
| import os |
There was a problem hiding this comment.
The import os statement should be at the top of the file with other imports, following Python's standard conventions. Placing it inside a function or a finally block is unconventional and can be less efficient.
![propel-code-bot[bot]](https://avatars.githubusercontent.com/in/1179004?s=60&v=4){kind=small}
abhishekg999
requested review from
Mandolaro,
adivate2021,
alanzhang25 and
justinsheu
|
✔️ Propel has finished reviewing this change. |
No description provided.