Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base worklist refactor #51

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Base worklist refactor #51

merged 2 commits into from
Nov 27, 2023

Conversation

michaelosthege
Copy link
Member

  • 🚚 Worklist class was split into three:
    • 🆕 BaseWorklist which does not support model-specific methods
    • 🆕 EvoWorklist with the same API as before
    • 🆕 FluentWorklist which is not yet implemented
  • ⚠️ Worklist() was deprecated and should be replaced by either of the above.

Follow-up work:

  • Splitting evotools.test_worklist.py up as well
  • Refactoring tests to use BaseWorklist/EvoWorklist as needed
  • Implementing FluentWorklist and its transfer method

As a separate commit to keep git history intact.
@michaelosthege michaelosthege self-assigned this Nov 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (08af830) 92.87% compared to head (01d0b6d) 93.04%.
Report is 7 commits behind head on master.

Files Patch % Lines
robotools/worklists/base.py 86.54% 23 Missing ⚠️
robotools/worklists/utils.py 96.90% 3 Missing ⚠️
robotools/fluenttools/worklist.py 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   92.87%   93.04%   +0.16%     
==========================================
  Files          13       18       +5     
  Lines        1011     1050      +39     
==========================================
+ Hits          939      977      +38     
- Misses         72       73       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelosthege michaelosthege marked this pull request as ready for review November 24, 2023 18:17
Copy link
Member Author

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewed after the weekend 👍

@michaelosthege
Copy link
Member Author

Checked the coverage gaps. Nothing critical.

@michaelosthege michaelosthege added the enhancement New feature or request label Nov 27, 2023
@michaelosthege michaelosthege merged commit 6e12afb into master Nov 27, 2023
@michaelosthege michaelosthege deleted the base-worklist-refactor branch November 27, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants