Merge pull request QuantConnect#2 from QuantConnect/refactor-naming-o…

…rder-location Renames and moves
JosueNina · Jun 21, 2021 · 93fbc01 · 93fbc01
2 parents a7efe5f + 63c07e5
commit 93fbc01
Show file tree

Hide file tree

Showing 16 changed files with 26 additions and 321 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -15,8 +15,11 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
-      - name: Build
-        run: dotnet build /p:Configuration=Release /v:quiet /p:WarningLevel=1 MyCustomDataType.sln
+      - name: BuildDataSource
+        run: dotnet build ./QuantConnect.DataSource.csproj /p:Configuration=Release /v:quiet /p:WarningLevel=1
+
+      - name: BuildTests
+        run: dotnet build ./tests/Tests.csproj /p:Configuration=Release /v:quiet /p:WarningLevel=1
 
       - name: Run Tests
-        run: dotnet test ./Tests/bin/Release/net5.0/Tests.dll
+        run: dotnet test ./tests/bin/Release/net5.0/Tests.dll
diff --git a/DataConverterScript/PythonConverterScript.py b/DataConverterScript/PythonConverterScript.py
diff --git a/DataProcessing/DataProcessing.csproj b/DataProcessing/DataProcessing.csproj
diff --git a/DataProcessing/Program.cs b/DataProcessing/Program.cs
diff --git a/DataProcessing/VendorDataDownloaderConverter.cs b/DataProcessing/VendorDataDownloaderConverter.cs
diff --git a/Tests/CustomDataAlgorithm.cs → Demonstration.cs b/Tests/CustomDataAlgorithm.cs → Demonstration.cs
@@ -18,6 +18,7 @@
 using QuantConnect.Util;
 using QuantConnect.Orders;
 using QuantConnect.Algorithm;
+using QuantConnect.DataSource;
 
 namespace QuantConnect.DataLibrary.Tests
 {

diff --git a/DataLibrary/MyCustomDataType.cs → MyCustomDataType.cs b/DataLibrary/MyCustomDataType.cs → MyCustomDataType.cs
@@ -18,11 +18,10 @@
 using NodaTime;
 using ProtoBuf;
 using System.IO;
-using QuantConnect;
 using QuantConnect.Data;
 using System.Collections.Generic;
 
-namespace QuantConnect.DataLibrary
+namespace QuantConnect.DataSource
 {
     /// <summary>
     /// Example custom data type

diff --git a/MyCustomDataType.sln b/MyCustomDataType.sln
diff --git a/DataLibrary/DataLibrary.csproj → QuantConnect.DataSource.csproj b/DataLibrary/DataLibrary.csproj → QuantConnect.DataSource.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>net5.0</TargetFramework>
-    <RootNamespace>QuantConnect.DataLibrary</RootNamespace>
+    <RootNamespace>QuantConnect.DataSource</RootNamespace>
   </PropertyGroup>
 
   <ItemGroup>
@@ -12,4 +12,15 @@
     <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
   </ItemGroup>
 
+  <ItemGroup>
+    <Compile Remove="tests\**" />
+    <EmbeddedResource Remove="tests\**" />
+    <None Remove="tests\**" />
+    <Compile Remove="Demonstration.cs" />
+    <None Remove=".gitignore" />
+    <None Remove="process.sample.ipynb" />
+    <None Remove="process.sample.py" />
+    <None Remove="process.sample.sh" />
+  </ItemGroup>
+
 </Project>
diff --git a/README.md b/README.md
@@ -15,9 +15,8 @@ It is composed by example .Net solution for the data type and converter scripts.
 
 The solution targets dotnet 5, for installation instructions please follow [dotnet download](https://dotnet.microsoft.com/download).
 
-The data downloader and converter script can be developed in different ways: Python script, C# or Python jupyter notebook or even a bash script.
+The data downloader and converter script can be developed in different ways: Python script, Python jupyter notebook or even a bash script.
 - The python script should be compatible with python 3.6.8
-- C# notebook will run using [dotnet interactive](https://github.com/dotnet/interactive)
 - Bash script will run on Ubuntu Bionic
 
 Specifically, the enviroment where these scripts will be run is [quantconnect/research](https://hub.docker.com/repository/docker/quantconnect/research) based on [quantconnect/lean:foundation](https://hub.docker.com/repository/docker/quantconnect/lean).
@@ -89,7 +88,6 @@ Data converter scripts will be in charge of fetching new data and processing it
 TODO:
 
 ##### Python Notebook
-##### CSharp Notebook
 ##### Python Script
 ##### Bash Script
 

diff --git a/Data/alternative/mycustomdatatype/spy.csv → output/alternative/mycustomdatatype/spy.csv b/Data/alternative/mycustomdatatype/spy.csv → output/alternative/mycustomdatatype/spy.csv
diff --git a/DataConverterScript/BashConverterScript.sh → process.sample.ipynb b/DataConverterScript/BashConverterScript.sh → process.sample.ipynb
diff --git a/...erterScript/CSharpConverterNotebook.ipynb → process.sample.py b/...erterScript/CSharpConverterNotebook.ipynb → process.sample.py
diff --git a/...erterScript/PythonConverterNotebook.ipynb → process.sample.sh b/...erterScript/PythonConverterNotebook.ipynb → process.sample.sh