Skip to content

issue/1627: Fix "Gravatar" typos #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

issue/1627: Fix "Gravatar" typos #1628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,10 @@ Here are all of the extension settings with their default values. To change any
// Priority of encoding
"svn.experimental.encoding_priority": [],

// Url for the gravitar icon using the <AUTHOR>, <AUTHOR_MD5> and <SIZE> placeholders
// Url for the gravatar icon using the <AUTHOR>, <AUTHOR_MD5> and <SIZE> placeholders
"svn.gravatar.icon_url": "https://www.gravatar.com/avatar/<AUTHOR_MD5>.jpg?s=<SIZE>&d=robohash",

// Use garavatar icons in log viewers
// Use gravatar icons in log viewers
"svn.gravatars.enabled": true,

// Ignores the warning when SVN is missing
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,15 +1073,15 @@
},
"svn.gravatar.icon_url": {
"type": "string",
"description": "Url for the gravitar icon using the <AUTHOR>, <AUTHOR_MD5> and <SIZE> placeholders",
"description": "Url for the gravatar icon using the <AUTHOR>, <AUTHOR_MD5> and <SIZE> placeholders",
"examples": [
"https://www.gravatar.com/avatar/<AUTHOR_MD5>.jpg?s=<SIZE>&d=https%3A%2F%2Fui-avatars.com%2Fapi%2F/<AUTHOR>/128"
],
"default": "https://www.gravatar.com/avatar/<AUTHOR_MD5>.jpg?s=<SIZE>&d=robohash"
},
"svn.gravatars.enabled": {
"type": "boolean",
"description": "Use garavatar icons in log viewers",
"description": "Use gravatar icons in log viewers",
"default": true
},
"svn.ignoreMissingSvnWarning": {
Expand Down
4 changes: 2 additions & 2 deletions src/historyView/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,13 +216,13 @@ export function getCommitIcon(
return gravatar;
}

const gravitarUrl = configuration
const gravatarUrl = configuration
.get("gravatar.icon_url", "")
.replace("<AUTHOR>", author)
.replace("<AUTHOR_MD5>", md5(author))
.replace("<SIZE>", size.toString());

gravatar = Uri.parse(gravitarUrl);
gravatar = Uri.parse(gravatarUrl);

gravatarCache.set(author, gravatar);

Expand Down