Skip to content

fix type error in queue.hpp, improve distributability and documentation #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

keyan3
Copy link

@keyan3 keyan3 commented Nov 3, 2021

Code changes:

  • tiny change in queue.hpp that allows gosdt c++ code to compile on clang with versions of tbb after '2020_U3' (solves this issue i opened previously)

Distribution:

  • added a Github Actions workflow which uses cibuildwheel to build wheels so the gosdt c++ extension doesn't need to be built on every users machine. This also prevents users from having to install the dependencies like tbb, etc.
  • added a requirements.txt that makes installing the dependencies for the local python wrapper easier
  • add MIT license (i can change this to any other license you'd like, just let me know)
  • increment version number

Documentation:

  • in README, distinguish between the local python wrapper and an sklearn-style wrapper that we have included in the imodels interpretable ML package
  • add installation test notebook which trains and tests on COMPAS dataset
  • provide more package information in setup.py for users who install gosdt via pip (kept jimmy.projects.lin as contact email, let me know if this should be updated)

let me know if you have any questions or concerns!

@keyan3 keyan3 changed the title fix type error in queue.hpp and set up for distribution fix type error in queue.hpp, improve distributability and documentation Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants