Replace 'IDE Key' terminology with 'Debug Trigger' #7
Conversation
The 'IDE Key' concept hasn't been a thing for a long time, and perpetuating it through hints and documentation is not a good idea. The pre-defined values also make no sense, as they should refer to a **user's** name, and not an IDE name. It is now called 'trigger' and the same cooking value can be used for Xdebug Cloud.
|
I had totally missed those. I have made this change now, and also set up the test runner locally. Everything is green for me. |
| <option value="macgdbp">MacGDBp</option> | ||
| <option value="VSCODE">VSCode</option> | ||
| </datalist> | ||
| <label for="debugtrigger">Debug Trigger or Xdebug Cloud Key</label> |
There was a problem hiding this comment.
what is "Xdebug Cloud Key" in this context?
There was a problem hiding this comment.
It is the key that you can use with https://xdebug.cloud — the cloud service uses the value of the same XDEBUG_SESSION cookie, to link that incoming HTTP/Xdebug connection with an IDE, that has registered with the cloud service with the same value.
It can also be set with the xdebug.cloud_id setting, but it's much easier to be able to set/override it through the session cookie, as this would allow every different developer (or rather, browser profile) to have their own connection.
src/options.html
Outdated
| <option value="VSCODE">VSCode</option> | ||
| </datalist> | ||
| <label for="debugtrigger">Debug Trigger or Xdebug Cloud Key</label> | ||
| <input type="text" id="debugtrigger" placeholder="Debug trigger or Xdebug Cloud Key" value=""> |
There was a problem hiding this comment.
Should the placeholder perhaps also be YOUR-NAME - to show the default?
There was a problem hiding this comment.
That's a good plan. I have pushed that change.
No description provided.