First version of loop visualization #461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP - Without tests and without grouping.
Print simple loops successfully.
Show nested loops.
Add while.
Improve loop detection, it supports do { } while()
Rebase to develop
1. Add tests. 2. Fix empty iterations. Problems: break out of the loop.
Fix using instrumented code in class loading.
Fix calculations of indents in output.
1. Fix multithreaded loop visualization. 2. Fix single-iteration loop visualization.
Remove all "lonely" (not-referred) labels from trace.
Add simple Java tests.
Fixes after rebase.
Fix case when there is more than one label action on same level: two loops in a row or lone label before loop.
Fix the case when prefix call depth is not equal to actual call depth.
More fixed of corner cases: 1. Unlink "back branch" events in case when the last event in iteration is deep call. 2. Decrease "prefix depth" for the loop node and iteration node when needed.
Regenerate presentations. Some new presentations are "bad": contain unprocessed loop events. Work for next version.
Support untaken conditional back branches.
Regenerate presentations after rebase.
lev-serebryakov-jetbrains
force-pushed
the
lev-serebryakov/loops-visualization
branch
from
75841b6 to
1141230
Compare
|
We've decided to proceed on the plugin side |
|
@lev-serebryakov-jetbrains, please rename the branch to indicate that it should not be deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first, incomplete, version of loop visualization.
Some constructs are not supported (yet).
Main unsupported feature is breaking loop and exiting from the middle of the loop. In simple cases such trace will contain last (incomplete) iteration events out of the loop, and in more complex cases loop is not recognized at all and trace will contain "raw" loop events, like labels and jumps.
Some regenerated presentations contain unprocessed "raw" loop events due to problems described above.