Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support thread pools in the general-purpose model checking API #447

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Support thread pools in the general-purpose model checking API #447

wants to merge 11 commits into from

Conversation

eupp
Copy link
Collaborator

@eupp eupp commented Jan 21, 2025

No description provided.

@eupp eupp mentioned this pull request Jan 22, 2025
Merged
5 tasks
@eupp eupp force-pushed the run-with-lincheck-api branch from 5ef8842 to ba7d010 Compare January 24, 2025 23:44
Base automatically changed from run-with-lincheck-api to develop January 28, 2025 09:48
@ndkoval
Copy link
Collaborator

ndkoval commented Jan 28, 2025

@eupp please rebase the PR

@eupp eupp force-pushed the run-with-lincheck-api-thread-pools branch from 8e615e8 to f241ebb Compare January 28, 2025 20:15
@eupp
Copy link
Collaborator Author

eupp commented Jan 28, 2025

@ndkoval rebased

@eupp eupp requested a review from ndkoval January 28, 2025 20:20
eupp added 11 commits January 31, 2025 13:06
@eupp
add thread pool test for runConcurrentTest
7478c93 
Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp
add separate expected trace files for each jdk version for the thread…
e5f1d17 
… pool test

Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp
fix Java lambda class filtering in test logs
74641a2 
Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp
support ThreadPoolExecutor on newer versions of JDK
2fe5f02 
* On these JDK versions, `JavaLangAccess.start` API is used to start threads inside a thread pool.

Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp
also instrument ThreadFlock jdk class, since it also uses `JavaLang…
5f8be04 
…Access.start`

Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp
fixes after rebase
8e17cfc 
Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp
gpmc trace reporter: print function result if its trace is expanded
df09211 
Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp
fix thread pool test
6027cd7 
Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp
fix thread pool tests traces
ee7861a 
Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp
avoid Java's lambdas in thread pool test
aa67f96 
Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp
remove Java's lambda filtering (it does not work reliably anyway)
fd817a9 
Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp eupp force-pushed the run-with-lincheck-api-thread-pools branch from 9e4dc72 to fd817a9 Compare January 31, 2025 12:07
ndkoval
ndkoval approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@ndkoval ndkoval left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please rebase onto develop before merging.

Also, let's create a separate issue about filtering out unnecessary events related to the executor internals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkoval ndkoval ndkoval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eupp @ndkoval