Wrap Icon in TopMenuButtonImpl in a TooltipBox to be able to show a tooltip for Toolbar menu items #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I wrote, unfortunately the background color of the tooltip is not correct in light theme, it still uses a dark color. OFC it could be solved with specifying the Probably something in themes should be modified. Can you help with this @zsmb13? Thanks! |
balazsgerlei
force-pushed
the
add-toolbar-tooltips
branch
from
9b78853 to
b6c8ce9
Compare
…ooltip for Toolbar menu items - On Android, long pressing on a Toolbar menu item should display the menu items' names in a tooltip - The Tooltip's background color is not correct yet in light mode (it uses a dark color for some reason) - Content description is used as the tooltip text
balazsgerlei
force-pushed
the
add-toolbar-tooltips
branch
from
b6c8ce9 to
051ec1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #476