Fix to Issue #46 - Factory.php attempting to create relationship for fields with {$class}_id #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factory.php was not taking into account fields that have `{$class}_id` as their primary key instead of `id` eg `user_id` as the primary key for the `users` table. - fixed and tests still pass
Put my info in the composer.json so that I can submit the package to packagist and pull it in with the fixed file instead of my changes being undone when composer updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factory.php was not taking into account fields that have
{$class}_idas their primary key instead ofideguser_idas the primary key for theuserstable. - fixed and tests still pass.All existing test passing but sorry - I'm only half way into "Laravel Testing Decoded" so not confident enough to write additional test as I get to the
if (static::$isSaving and preg_match('/([A-z]+)[-_]id$/i', $field, $matches))
line (c. 330) and I'm not sure you want to set the $isSaving to true & start saving to a db.