Fix for issue #6 #17
Open
Fix for issue #6 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using fix suggested by sorora in issue #6 thread as it worked for me. NOT authored by myself, pulled from this commit here https://github.com/sorora/Laravel-Test-Helpers/commit/4658c228959f03ca46a4c8c5bdfdfb2f34fe65b4 reduced switch to 2 cases as relationship method only uses 2 arguments ($relation, $foreignKey) correct? Also 1st time pull request so apologies for doing anything wrong :P
Author
|
Bump. Please could you take a look at this and merge it if you're happy with it? Its a pain to keep having to edit the file when the composer package updates or I install a new project. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using fix suggested by sorora in issue #6 thread as it worked for me. NOT authored by myself, pulled from this commit here https://github.com/sorora/Laravel-Test-Helpers/commit/4658c228959f03ca46a4c8c5bdfdfb2f34fe65b4 reduced switch to 2 cases as relationship method only uses 2 arguments ($relation, $foreignKey) correct?
Also 1st time pull request so apologies for doing anything wrong :P