Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did the refitting without using primitives for phase dependent shifts. This should fix nearly everything. There is a weird peak in phase 1 as shown here: https://s3df.slac.stanford.edu/people/rodwyer1/dir41526/index.html, which this will NOT fix. I don't think, however, that that weird peak is due to a phase or sensor based shift. It certainly isn't phase related, but sensor stuff would have been smeared out to produce a broad feature not something sharp like this. This feels more like the phase dependence changes slightly mid run. In any case, I think its not too bad a problem tbh (this phase shift problem is way worse). I'd push, run this, and see if we are okay with the resultant timing distribution (I suspect we will be).