Skip to content

fix: aria-selected does work on Apple devices #6058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alanpoulain
Copy link

@alanpoulain alanpoulain commented Jul 30, 2025

I'm not sure to understand why the condition was added, aria-selected seems to work fine on Apple devices and this condition prevents Testing Library to work on Apple devices:

findByRole("option", { name: "option B", selected: true }).should("exist")

The original PR was #5758, @Ke1sy could you maybe explain why you have added this?

Copy link

changeset-bot bot commented Jul 30, 2025

⚠️ No Changeset found

Latest commit: 78441b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant