Skip to content

only show minimum if it is bigger than 0#3

Open
fuddl wants to merge 2 commits into
JeanFred:masterfrom
fuddl:patch-1
Open

only show minimum if it is bigger than 0#3
fuddl wants to merge 2 commits into
JeanFred:masterfrom
fuddl:patch-1

Conversation

@fuddl

@fuddl fuddl commented Oct 31, 2019

Copy link
Copy Markdown

I think the headers are unnecessary when the threshold is 0

@codecov

codecov Bot commented Oct 31, 2019

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.68%. Comparing base (46484f5) to head (f09c3fe).
⚠️ Report is 295 commits behind head on master.

Files with missing lines Patch % Lines
integraality/property_statistics.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   71.80%   70.68%   -1.13%     
==========================================
  Files           3        3              
  Lines         376      382       +6     
  Branches       54       56       +2     
==========================================
  Hits          270      270              
- Misses         97      103       +6     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeanFred JeanFred self-requested a review November 4, 2019 17:29
@JeanFred

JeanFred commented Nov 4, 2019

Copy link
Copy Markdown
Owner

Thanks for the contribution @fuddl! I think it makes sense :)

That part of the code was untested so I have just added some in 588dae8. Would you mind rebasing on the latest master?
If you feel up for it, you can also add another test that would cover this new behaviour (if not, that’s fine, I would do it myself :) )

@fuddl

fuddl commented Nov 5, 2019

Copy link
Copy Markdown
Author

I have no idea how to rebase branches accross forks 😅

But i'll find out

@JeanFred

JeanFred commented Nov 5, 2019

Copy link
Copy Markdown
Owner

I have no idea how to rebase branches accross forks sweat_smile

But i'll find out
No worries, let me know if I can help :)

Off the top of my head, and assuming my repo is still the origin remote, it’s probably, from your branch something like
git fetch origin && git rebase origin/master

@JeanFred JeanFred force-pushed the master branch 2 times, most recently from d28793a to 6963040 Compare April 24, 2020 19:49
@JeanFred JeanFred force-pushed the master branch 2 times, most recently from 0b7171b to a361dfd Compare May 10, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants