Skip to content

Update vue-numeric-input.vue #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update vue-numeric-input.vue #5

wants to merge 1 commit into from

Conversation

Trigur
Copy link

@Trigur Trigur commented Feb 5, 2019

Fix NaN when value is empty

@codecov-io
Copy link

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files           1        1           
  Lines          56       56           
  Branches       16       16           
=======================================
  Hits           54       54           
  Partials        2        2
Impacted Files Coverage Δ
src/vue-numeric-input.vue 96.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7a184...3b2e066. Read the comment docs.

@MartinKleikamp
Copy link

Why this is closed? I do not find the merge in master. In my opinion this resolves a valid issue with initial null values, as consequence you have to click twice on + or - initially. I tested this pull request successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants