Skip to content

Fix permission settings for QOTW submissions channel in QOTW jobs #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

Defective4
Copy link
Contributor

@Defective4 Defective4 commented Apr 13, 2025

JavaBot is meant to revoke users' permissions to send messages in threads in QOTW submissions channel after the QOTW submission period ends.
Currently after the submission period ends the bot resets all of the channel's role overrides for @everyone and doesn't deny the MESSAGE_SEND (and other) permissions until the next submission period starts, meaning that all members are allowed to send messages in the submissions channel during that short window of time.
Also since the bot resets the channel permissions at the start and end of submission period and does NOT set other permissions such as CREATE_PRIVATE_THREADS and MESSAGE_ADD_REACTION, all members are allowed to create new threads manually and add message reactions at all times.
This pull request fixes both of these issues by ensuring that MESSAGE_SEND permission is set to denied at the end of the submission period, and by denying the following permissions at both start and end of the period:

  • CREATE_PRIVATE_THREADS
  • CREATE_PUBLIC_THREADS
  • MESSAGE_ADD_REACTION

@Defective4 Defective4 requested a review from a team as a code owner April 13, 2025 20:20
Copy link
Member

@danthe1st danthe1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and it works in my tests.

@danthe1st danthe1st merged commit 94b36d6 into Java-Discord:main Apr 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants