Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Webhook Message Links #321

Merged
merged 4 commits into from
Jul 24, 2022
Merged

User Webhook Message Links #321

merged 4 commits into from
Jul 24, 2022

Conversation

jasonlessenich
Copy link
Member

Closes #278

@jasonlessenich jasonlessenich added the enhancement Improvement of an already existing feature label Jul 23, 2022
@jasonlessenich jasonlessenich self-assigned this Jul 23, 2022
@jasonlessenich jasonlessenich requested a review from a team as a code owner July 23, 2022 23:36
@jasonlessenich
Copy link
Member Author

This would work best with buttons imo. However, Minn's Webhook Lib doesn't support them (yet: MinnDevelopment/discord-webhooks#46).
Some dude actually made a PR for this, but never finished and just closed their PR at some point (MinnDevelopment/discord-webhooks#56).

Lemme see if I can get his PR to work soonTm

@jasonlessenich jasonlessenich marked this pull request as draft July 24, 2022 00:17
@jasonlessenich jasonlessenich marked this pull request as ready for review July 24, 2022 00:53
@jasonlessenich
Copy link
Member Author

I fixed the issues myself and made this work now 👍

@jasonlessenich jasonlessenich merged commit 0d51e76 into dynxsty/dih4jda Jul 24, 2022
@jasonlessenich jasonlessenich deleted the dynxsty/webhook_message_links branch July 24, 2022 07:35
@jasonlessenich jasonlessenich mentioned this pull request Jul 24, 2022
Merged
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danthe1st danthe1st danthe1st approved these changes

@MoonTM-GIT MoonTM-GIT MoonTM-GIT approved these changes

Assignees

@jasonlessenich jasonlessenich

Labels
enhancement Improvement of an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonlessenich @danthe1st @MoonTM-GIT