Add the ability to add a ⭐ to a message in the #starboard channel as well as the original message #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahilasopa
requested changes
Jan 15, 2022
| } | ||
|
|
||
| @Override | ||
| public void onMessageDelete(@NotNull MessageDeleteEvent event) { | ||
| removeMessageFromStarboard(event.getGuild(), event.getMessageId()); | ||
| } | ||
|
|
||
| private void updateSbReactionCounts(GenericMessageReactionEvent event, StarBoardConfig config, String messageId, String remoteTextChannelId) { | ||
| Objects.requireNonNull(event.getGuild().getTextChannelById(remoteTextChannelId)).retrieveMessageById(messageId).queue(message -> { |
There was a problem hiding this comment.
replace Objects.requireNonNull with a null check Objects.requireNonNull throws exceptions
|
|
||
| private int getUniqueStarCounts(Message starboardMessage, Message originalMessage, StarBoardConfig config){ | ||
| try { | ||
| List<User> list = originalMessage.retrieveReactionUsers(config.getEmotes().get(0)).takeAsync(this.getReactionCountForEmote(config.getEmotes().get(0), originalMessage)).get(); |
There was a problem hiding this comment.
give these variables a valid name instead so list
| private int getUniqueStarCounts(Message starboardMessage, Message originalMessage, StarBoardConfig config){ | ||
| try { | ||
| List<User> list = originalMessage.retrieveReactionUsers(config.getEmotes().get(0)).takeAsync(this.getReactionCountForEmote(config.getEmotes().get(0), originalMessage)).get(); | ||
| List<User> list2 = starboardMessage.retrieveReactionUsers(config.getEmotes().get(0)).takeAsync(this.getReactionCountForEmote(config.getEmotes().get(0), starboardMessage)).get(); |
src/main/java/net/javadiscord/javabot/events/StarboardListener.java
Outdated
Show resolved
Hide resolved
|
I'm sorry to say that, but I have to close this PR, as we're going to refactor the whole starboard to use the H2 Database. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : Ability to add a ⭐from Starboard and Original Message
Its notable that we cannot ⭐ a message directly from the starboard.
I have added the feature to vote on the message both from the starboard and the original message. With this, I have implemented it in a way that it counts a User only once even if the User votes on both the messages.
It closes the issue : Ability to add a ⭐from Starboard and Original Message