[찬인] 문자열 덧셈 계산기 #11
Open
[찬인] 문자열 덧셈 계산기 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csbsjy
reviewed
Mar 3, 2020
|
|
||
| import java.util.List; | ||
|
|
||
| public interface SplitStrategy { |
csbsjy
reviewed
Mar 4, 2020
|
|
||
| public class Calculator { | ||
|
|
||
| public static int calculate(String expression) { |
There was a problem hiding this comment.
멤버변수에 대한 의존성이 없어서..?
SplitStrategy는 인터페이스로 작성해야 하니까 그렇게 할수 없었구..
static으로 작성하려면 default 메서드가 되야했으니까..!!
There was a problem hiding this comment.
이펙티브자바 140 페이지를 참고하여 기본생성자를 private 으로 명시하고 인스턴스화를 막아보는건 어떨까?
csbsjy
reviewed
Mar 4, 2020
|
|
||
| @DisplayName("null 또는 공백을 입력할 경우 0을 반환") | ||
| @ParameterizedTest | ||
| @NullAndEmptySource |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.