ci: support conditional required checks with path filtering#576
Merged
Conversation
Use dorny/paths-filter to detect file changes at job level instead of workflow level. This ensures workflows always run and report a status to GitHub, solving the "Waiting for status" issue when path filters don't match. Changes: - pr-tests.yml: Add changes detection job, skip-tests job reports success when no relevant files changed - codeql.yml: Add changes detection job, skip-analyze job reports success when no relevant files changed, schedule/dispatch always run Both skip jobs use the same name as their actual counterparts so GitHub Ruleset correctly identifies the check status. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dorny/paths-filter@v3to detect file changes at job level instead of workflow levelProblem
GitHub Ruleset requires
Run Unity TestsandAnalyze C# Codechecks to pass before merge. However, these workflows have path filters that prevent them from running when only documentation files change. This causes PRs to show "Waiting for status to be reported" indefinitely.Solution
Move path filtering from workflow level to job level:
dorny/paths-filterto check if relevant files changednameas actual jobSince both jobs share the same
name, GitHub sees them as the same check and the Ruleset requirement is satisfied.Changes
pr-tests.ymlchangesjob,skip-testsjob with same name asrun-testscodeql.ymlchangesjob,skip-analyzejob with same name asanalyze; schedule/dispatch always runTest Plan
skip-*jobs run, checks pass immediately🤖 Generated with Claude Code