fix(ci): improve CodeQL analysis quality with Unity build#574
Closed
JasonXuDeveloper wants to merge 1 commit into
Closed
fix(ci): improve CodeQL analysis quality with Unity build#574JasonXuDeveloper wants to merge 1 commit into
JasonXuDeveloper wants to merge 1 commit into
Conversation
JasonXuDeveloper
force-pushed
the
fix/codeql-build-quality
branch
from
cf90bf5 to
5ea2162
Compare
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
- Use game-ci/unity-builder to compile Unity scripts before CodeQL analysis for proper type information - Create centralized .github/unity-config.env for Unity CI settings - Both codeql.yml and unity-tests.yml load from config file at runtime - Inputs can still override config values when needed This resolves the "Low C# analysis quality" warning by providing CodeQL with compiled assemblies that have full type information. Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
JasonXuDeveloper
force-pushed
the
fix/codeql-build-quality
branch
from
5ea2162 to
7971ec3
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
2 similar comments
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Owner
Author
|
Closing this PR - the added complexity (Unity build in CodeQL, license seat conflicts) isn't worth the marginal improvement in analysis quality. The existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
build-mode: nonetobuild-mode: manualWhy
The previous
build-mode: nonecouldn't resolve Unity types properly, resulting in:By actually compiling the Unity project, CodeQL can analyze the compiled assemblies with full type information.
Test plan
🤖 Generated with Claude Code