fix: resolve remaining CodeQL security issues#573
Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
- Use 'using' statements in tests to ensure JAction disposal even when assertions throw (JActionTests.cs) - Add explicit job-level permissions to all workflow jobs (release.yml, unity-tests.yml, pr-tests.yml, dco-check.yml) - Exclude cs/path-combine rule (false positive for internal API values) Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
JasonXuDeveloper
force-pushed
the
fix/codeql-remaining-issues
branch
from
df7b2ae to
4f9d96e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Path.Combinewith string concatenation for Unity paths to avoid potential path traversal issuesusingstatements in tests to ensureJActiondisposal even when assertions throwChanges
C# Code Fixes
Path.Combinewith string concatenation for Resources pathsPath.Combinewith string concatenation for file system pathsvartousing varfor 6 tests to ensure disposal on assertion failureWorkflow Permission Fixes
validate,run-tests, andprepare-releasejobstestjobrun-testsjobdco-checkjobTest plan
🤖 Generated with Claude Code