Combine multiple remediations #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
is there also the same PR upstream? |
Collaborator
Author
|
No, we haven't created upstream pr about remediations yet. There's an issue about it anthonyharrison#3 |
Member
|
please create one, the goal is not to keep this fork, but at some point to go back to the original library. |
|
LGTM. |
S-Panta
approved these changes
Oct 28, 2024
individual-it
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously remediations of vulnerability were not appended (only last remediation was stored).
So, this pr combines
detailsof all the remediations (regardless of the category: mitigation, no_fix_planned, none_available, vendor_fix, workaround) of a vulnerability and sets it inremediationskey.Upstream pr: anthonyharrison#6