Add HTML reporting #299
Open
Add HTML reporting #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzbrooks
commented
Sep 7, 2024
reports/src/main/kotlin/com/jakewharton/diffuse/report/html/JarDiffHtmlReport.kt
Show resolved
Hide resolved
jzbrooks
commented
Sep 8, 2024
| if (diff.added.isNotEmpty()) { | ||
| br() | ||
| diff.added.forEach { | ||
| span { unsafe { raw("+ $it".htmlEncoded) } } |
There was a problem hiding this comment.
This is kinda lame. kotlinx.html appears to encode some special chars, but not Δ or →.
It would probably be an improvement to somehow avoid using → in the CF entity toString implementation, but it's not a huge deal (other than allocating every string again…)
There was a problem hiding this comment.
Replacing → with -> would also obviate the need for this. It's easy to replace Δ based on the output type because it's written in :reports not in a Method.toString in :formats.
It's maybe a formatting landmine to not have a generic htmlEncoding mechanism.
jzbrooks
force-pushed
the
html-reporting
branch
from
4102306 to
4a86799
Compare
jzbrooks
force-pushed
the
html-reporting
branch
from
238149c to
992ac37
Compare
|
Here's a PDF export for ref |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively quick step forward for HTML reports, which would be useful for some reporting I'd like to add to our CI pipeline.
(Eventually) Resolves #83