Add NetworkManager module #518
Conversation
There was a problem hiding this comment.
Thanks for your hard work on this so far. There's a few changes needed here, but generally the code looks solid & this should be a good foundation for the module.
If you can also resolve the formatting issue, and squash commits down into one please that'd be great.
Any questions let me know.
|
@JakeStanger let me know if you think the code is ready to merge in its current state :) |
There was a problem hiding this comment.
It's getting there generally, but there's still a few things pending & I'm still not 100% sure about the signals crate - if you can get back to my Qs pls just to clear up some potential concerns.
I need to give this a proper test too, so I'll try and do that as soon as I can.
There was a problem hiding this comment.
Thanks for the work on the refactor, and apologies I haven't inputted a lot on this one for a while.
A couple of very small changes now, but outside of those the code lgtm now. I'll give this some tests and report back.
Is there anything else you want to add at the PR at this stage, or do you reckon we're go for the initial version?
Looks like it's all working as intended. I've tested Ethernet and Wifi and toggling connections in both cases causes instant updates. |
No as far as I'm concerned we're good to go! |
|
Sorry for delay on this (again). There's a merge conflict outstanding - if you can resolve that I'll add the docs and merge :) |
|
Merged and re-tested 👍 The |
JakeStanger
force-pushed
the
feat/networkmanager
branch
from
63f2871 to
638cf12
Compare
JakeStanger
force-pushed
the
feat/networkmanager
branch
from
638cf12 to
6d0fe4c
Compare
There was a problem hiding this comment.
Apologies for the huge delay on this, and thanks again for all your work. I've finally got round to putting the finishing touches on it.
FYI, I've made some basic refactors and renamed the module/feature flag to network_manager.
I'll merge this in a few mins and it'll be available in the git build.
Implements a module displaying (very) basic network connectivity from NetworkManager.
First step towards resolving #148.