Native modules inside custom modules #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeStanger
force-pushed
the
feat/modules-in-custom
branch
4 times, most recently
from
0bfd6b7 to
9430fe4
Compare
|
Edge cases sorted. I want to spend some more time polishing the code & update the docs then I think this is ready. |
JakeStanger
force-pushed
the
feat/modules-in-custom
branch
2 times, most recently
from
3e3d32e to
a8b9baf
Compare
JakeStanger
force-pushed
the
feat/modules-in-custom
branch
2 times, most recently
from
8780ea4 to
976266e
Compare
JakeStanger
force-pushed
the
feat/modules-in-custom
branch
from
976266e to
ee8873a
Compare
JakeStanger
added a commit
that referenced
this pull request
Apr 1, 2024
Crash on startup if modules missing common options
JakeStanger
added a commit
that referenced
this pull request
Apr 1, 2024
- Crash on startup if modules missing common options - Crash on startup due to disable_popup incorrectly mandatory
nyadiia
pushed a commit
to nyadiia/ironbar
that referenced
this pull request
May 3, 2024
- Crash on startup if modules missing common options - Crash on startup due to disable_popup incorrectly mandatory
nyadiia
pushed a commit
to nyadiia/ironbar
that referenced
this pull request
May 3, 2024
- Crash on startup if modules missing common options - Crash on startup due to disable_popup incorrectly mandatory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to put native modules inside custom modules.
This works apart from a few (relatively) edge case. The code also needs refactoring.
Sticking this up for now so it's available - will revisit to get across the line in the near future.
Resolves #131.