Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume module #460

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Volume module #460

merged 4 commits into from
Mar 4, 2024

Conversation

JakeStanger
Copy link
Owner

@JakeStanger JakeStanger commented Feb 18, 2024

The volume module is now complete and stable enough that I believe it warrants opening a PR. The code is a bit rough in places so I'm going to refactor it over the next couple of weeks before it gets merged in. This hopefully also gives a chance for people to have a poke at it.

The initial version of the module provides the following:

  • A button on the bar which indicates volume level by icon
  • A popup with controls for output device switching, output device volume changing, and individual output stream (ie per program) level controls.
  • Support for Pulseaudio (inc pipewire-pulse).

To do still:

  • Fix a few edge cases (such as popup state when nothing is playing)
  • Add name and class elements to widgets
  • Ability to show more on the bar (such as current vol level)
  • More options
  • Write documentation
  • Update example config & styles

Resolves #50

@JakeStanger JakeStanger force-pushed the feat/volume branch 8 times, most recently from 5e44884 to 348d22f Compare March 3, 2024 15:52
@JakeStanger JakeStanger marked this pull request as ready for review March 3, 2024 15:52
@slowsage
Copy link
Contributor

slowsage commented Mar 4, 2024

I'm thinking of adding an audio device switcher using pactl subscribe to track events. Will wait for 1st cut of volume module to be merged. I want to add a way to show current audio device (headphone/speaker etc, next to volume icon.) with a way to customize the icons shown based on regex. Please lmk if you had any thoughts.

@JakeStanger
Copy link
Owner Author

It sounds like this may be most of the way to that already. The popup supports device switching, and you can display the current device name next to the icon on the bar.

The only part of that is missing is regex support. Generally I'm a little cautious of adding regex in as it can be a bit heavy-handed, and less intuitive to configure. That doesn't mean it's out the question, but I think it'd be worth opening an issue to discuss what you're after before jumping into anything.

@JakeStanger JakeStanger merged commit 3c7e434 into master Mar 4, 2024
8 checks passed
JakeStanger added a commit that referenced this pull request Mar 4, 2024
@JakeStanger JakeStanger deleted the feat/volume branch March 4, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume module
3 participants