Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable use of markup in clock module formats #439

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

Dridus
Copy link

@Dridus Dridus commented Feb 7, 2024

hello! this PR makes a simple change to allow the use of pango markup in clock formats. the plain label module does this, so I figured it wouldn't be out of place.

I read in the contributing guidance to open an issue or discussion as best practice, but since this is so small and I wanted it for myself I figured I'd just go straight to PR and I can close or revise it as you like.

thanks for writing ironbar!

@JakeStanger
Copy link
Owner

Thanks for the PR, agreed this makes sense to enable.

That particular contribution guideline is more for your own benefit, so that you don't spend time developing something that ultimately gets rejected. I appreciate you reading and otherwise sticking to the guidelines though :)

A couple of small changes please:

  • Since the clock module also offers format_popup, could you also enable pango there to keep things consistent?
  • Could you please update the clock module docs page to mention that markup is supported in each row of the config table?

I've got 0.14.1 hopefully going out this weekend, which'll be a bugfix only update. This can then follow after that and will likely be the first feature of 0.15.0.

@Dridus
Copy link
Author

Dridus commented Feb 8, 2024

@JakeStanger okay, those changes should be made. I also made the format one match the format_popup one in terms of using LabelBuilder, to be consistent. if it should be consistently not using builder or inconsistent though let me know.

@JakeStanger
Copy link
Owner

Thanks, lgtm. Consistency with the builder interface is definitely better.

If you can just squash down the commits pls, I think this is good to go.

@Dridus Dridus force-pushed the rmm/clock-label-markup branch from 39a1230 to d780c66 Compare February 8, 2024 15:44
…nd update documentation to reflect supporting Pango markup in both
@Dridus Dridus force-pushed the rmm/clock-label-markup branch from d780c66 to f4384b6 Compare February 9, 2024 04:33
@Dridus
Copy link
Author

Dridus commented Feb 9, 2024

I realized that I flubbed the squash somehow, so I corrected it in the second force-push.

@JakeStanger JakeStanger merged commit 1dcf6a0 into JakeStanger:master Feb 10, 2024
2 checks passed
@JakeStanger
Copy link
Owner

First feature of 0.15, cheers for your work on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants