feat: 잘못된 숫자 값에 대한 예외 처리 구현

Author: jay-so

.github/workflows/RandomReviewer.yml

@@ -8,45 +8,50 @@ on:
       - jay-so
       - iey704
       - yerimming
-      - makeUgreat
       - jiminseong
 
 jobs:
-  random-reviwer:
+  random-reviewer:
     runs-on: ubuntu-latest
     steps:
-      - id: random_reviwer
+      - id: random_reviewer
         uses: actions/github-script@v5
         with:
-          github-token: ${{ secrets.GITHUB_TOKEN }} 
+          github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
-            const candidate = ['jay-so', 'iey704', 'yerimming', 'makeUgreat', 'jiminseong'];
-            const randomReviewer = candidate[Math.floor(Math.random() * candidate.length)];
-            const comment = `@${randomReviewer} 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏`;
+            const candidates = ['jay-so', 'iey704', 'yerimming', 'jiminseong'];
+            const author = context.payload.pull_request.user.login;
+
+            // 작성자를 제외한 후보자 목록 만들기
+            const filteredCandidates = candidates.filter(candidate => candidate !== author);
+
+            // 랜덤 리뷰어 선택 (3명)
+            const randomReviewers = filteredCandidates.sort(() => Math.random() - 0.5).slice(0, 3);
+
+            // 메시지 생성
+            const comment = `@${randomReviewers.join(' @')} 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏`;
             console.log(`Comment: ${comment}`);
-            return { comment, reviewer: randomReviewer };
 
-      - name: comment PR
+            core.setOutput('comment', comment);
+            core.setOutput('reviewers', randomReviewers.join(','));
+
+      - name: Comment PR
         uses: actions/github-script@v5
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
-            const reviewer = '${{ steps.random_reviwer.outputs.reviewer }}';
-            const comment = `@${reviewer} 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏`;
-            
-            const { owner, repo } = context.repo;
-            const issue_number = context.issue.number;
-            
+            const reviewers = '${{ steps.random_reviewer.outputs.reviewers }}'.split(',');
+            const comment = `@${reviewers.join(' @')} 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏`;
+
             await github.rest.issues.createComment({
-              owner,
-              repo,
-              issue_number,
-              body: comment
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: context.issue.number,
+              body: comment,
             });
 
-      - name: Add Pull Request Reviewer
+      - name: Add Pull Request Reviewers
         uses: madrapps/add-reviewers@v1
         with:
-          reviewers: ${{ steps.random_reviwer.outputs.reviewer }}
-          token: ${{ secrets.GITHUB_TOKEN }}
-
+          reviewers: ${{ steps.random_reviewer.outputs.reviewers }}
+          token: ${{ secrets.GITHUB_TOKEN }}

src/constant/messages.mjs

@@ -3,6 +3,7 @@ import { USER_COMMAND, GAME_CONDITION } from './conditions.mjs';
 const MESSAGES = Object.freeze({
   startGuide: `숫자 야구 게임을 시작합니다.`,
   inputGuide: `숫자를 입력해주세요 : `,
+  inputError: `[Error] 잘못된 숫자 형식입니다.`,
   endGuide: `${GAME_CONDITION.maxLength}개의 숫자를 모두 맞히셨습니다! 게임종료`,
   replayGuide: `게임을 새로 시작하려면 ${USER_COMMAND.replay}, 종료하려면 ${USER_COMMAND.end}를 입력하세요.\n`,
 });

src/model/InputValidator.mjs

@@ -0,0 +1,34 @@
+import { USER_COMMAND, GAME_CONDITION } from '../constant/conditions.mjs';
+
+const InputValidator = {
+  /**
+   * 유효범위의 중복이 없는 3자리 숫자가 입력되었는지 검증
+   * @param {string} input //검증할 값
+   * @return {boolean} //입력값이 유효한 경우 true, 그렇지 않을 경우 false를 반환
+   */
+
+  hasValidNumber(input) {
+    const numberRegExp = /^\d+$/;
+    const isNumeric = numberRegExp.test(input);
+    const isValidLength = input.length === GAME_CONDITION.maxLength;
+    const isValidUnique = new Set(input).size === GAME_CONDITION.maxLength;
+    const isValidRange = !input.includes(GAME_CONDITION.limitNumber);
+
+    return isNumeric && isValidLength && isValidUnique && isValidRange;
+  },
+
+  /**
+   * 재시작 또는 종료 명령어와 일치하는지 검증
+   * @param {string} input //검증할 입력값
+   * @return {boolean} //입력값이 유효한 경우 true, 그렇지 않을 경우 false를 반환
+   */
+  hasValidCommand(input) {
+    const commandInput = parseInt(input, 10);
+
+    return (
+      commandInput === USER_COMMAND.replay || commandInput === USER_COMMAND.end
+    );
+  },
+};
+
+export default InputValidator;

src/view/InputView.mjs

@@ -1,15 +1,23 @@
 import { Console } from '@woowacourse/mission-utils';
+import { MESSAGES } from '../constant/messages.mjs';
+import InputValidator from '../model/InputValidator.mjs';
 
 const InputView = {
   async getUserNumber(message) {
     const userNumber = await Console.readLineAsync(message);
 
+    if (!InputValidator.hasValidNumber(userNumber))
+      throw new Error(MESSAGES.inputError);
+
     return parseInt(userNumber, 10);
   },
 
   async getUserCommand(message) {
     const userCommand = await Console.readLineAsync(message);
 
+    if (!InputValidator.hasValidCommand(userCommand))
+      throw new Error(MESSAGES.inputError);
+
     return parseInt(userCommand, 10);
   },
 };