Task completion callback called too many times #21

Activity

1. JamesMessinger commented on Jun 9, 2017

   

   JamesMessinger

   on Jun 9, 2017

   Member

   More actions

   Simplifyify just propagates events from Browserify. If you have multiple entry files, then there will be multiple Browserify instances propagating events, which is why any of the events can fire multiple times. So, for example, if you have 5 entry files, then you'd need to handle the "end" event like this:

       .on("end", function() {
           finished++;
           if (finished === 5) {
               done();
           }
       })

   However, I think you'll agree that this is neither an elegant nor a straightforward solution. Simplifyify should emit its own synthetic event when all of the bundles have finished building. Then you could simply handle that event instead of the "end" event.

       .on("finish", function() {
           done();
       })
2. JamesMessinger

   added

   enhancement

   on Jun 9, 2017
3. ozgrozer commented on Jun 10, 2017

   

   ozgrozer

   on Jun 10, 2017

   Author

   More actions

   Both of them don't work with Gulp Watch.