Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #760 #761

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Fix broken links #760 #761

merged 3 commits into from
Dec 4, 2024

Conversation

bpbond
Copy link
Member

@bpbond bpbond commented Dec 4, 2024

No description provided.

@bpbond bpbond requested a review from kdorheim December 4, 2024 14:58
@bpbond bpbond linked an issue Dec 4, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 4, 2024

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

Copy link

github-actions bot commented Dec 4, 2024

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

Copy link
Contributor

@kdorheim kdorheim Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same figure or is there a change? I'm having a hard time telling

@bpbond
Copy link
Member Author

bpbond commented Dec 4, 2024

The figure was regenerated but should be identical...

Screenshot 2024-12-04 at 12 20 12 PM

README.Rmd Outdated Show resolved Hide resolved
Copy link
Contributor

@kdorheim kdorheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ben, thanks for catching this broken links please see comments below.

@bpbond
Copy link
Member Author

bpbond commented Dec 4, 2024

Thanks @kdorheim ! And to be clear, credit to @cahartin on catching the problem.

Copy link

github-actions bot commented Dec 4, 2024

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

@kdorheim kdorheim merged commit a824780 into main Dec 4, 2024
10 checks passed
@kdorheim kdorheim deleted the readme-fix branch December 4, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken link on repo
2 participants