-
Notifications
You must be signed in to change notification settings - Fork 51
Acorn updates; go fetcher #1623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acorn updates; go fetcher #1623
Conversation
FYI @DavidHuber-NOAA |
@climbfuji I was toying with the idea of tweaking the compiler filtering logic for spack stack create env --template unified-dev --name test --site acorn --compiler [email protected] --keep-compilers [email protected],[email protected] and the default would go back to the original, i.e., no compiler filtering. In any case, I want a better way to specify exactly what I want so that I don't have, say, If that sounds good I can do either in this PR or in a separate one. |
A separate PR is a good idea imo |
#1618 was merged, please resolve the conflicts and mark this PR as ready/add reviewers and I will look at it. Thanks! |
@@ -2,6 +2,13 @@ | |||
# Portable way to get current directory | |||
SPACK_STACK_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) | |||
|
|||
hostname=$(hostname) | |||
case $hostname in | |||
alogin*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That hostname is very unfortunate. I can totally see other platforms using something like this, too ... but for now we don't have any other one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use hostname --fqdn
. I'll be out the next couple days but I'll update this when I get the chance. With that it can be alogin*ncep.noaa.gov or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add that when we need it - for now we're ok.
Summary
This PR:
Testing
Successfully built unified env on Acorn.
Applications affected
UWM, GW, GSI
Systems affected
go fetcher can be used wherever, and site maintainers may choose to add site-specific logic in setup.sh; otherwise no expected impacts to platforms other than Acorn
Dependencies
none
Issue(s) addressed
Fixes #1615
Fixes #1616
Fixes #1597
Addresses #1574 by adding workaround for Acorn
Checklist