Skip to content

Acorn updates; go fetcher #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 1, 2025

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Apr 29, 2025

Summary

This PR:

  • adds oneAPI 2024.2.1 on Acorn
  • adds util/fetch_go_deps.py
  • adds platform-specific logic for setup.sh (for loading modules, etc.)

Testing

Successfully built unified env on Acorn.

Applications affected

UWM, GW, GSI

Systems affected

go fetcher can be used wherever, and site maintainers may choose to add site-specific logic in setup.sh; otherwise no expected impacts to platforms other than Acorn

Dependencies

none

Issue(s) addressed

Fixes #1615
Fixes #1616
Fixes #1597
Addresses #1574 by adding workaround for Acorn

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@AlexanderRichert-NOAA
Copy link
Collaborator Author

FYI @DavidHuber-NOAA

@AlexanderRichert-NOAA
Copy link
Collaborator Author

AlexanderRichert-NOAA commented Apr 29, 2025

@climbfuji I was toying with the idea of tweaking the compiler filtering logic for spack stack create env so that I can just give it a list of the compiler specs that I want to keep. The invocation would be something like:

spack stack create env --template unified-dev --name test --site acorn --compiler [email protected] --keep-compilers [email protected],[email protected]

and the default would go back to the original, i.e., no compiler filtering. In any case, I want a better way to specify exactly what I want so that I don't have, say, intel creeping into my oneapi environment.

If that sounds good I can do either in this PR or in a separate one.

@climbfuji
Copy link
Collaborator

@climbfuji I was toying with the idea of tweaking the compiler filtering logic for spack stack create env so that I can just give it a list of the compiler specs that I want to keep. The invocation would be something like:

spack stack create env --template unified-dev --name test --site acorn --compiler [email protected] --keep-compilers [email protected],[email protected]

and the default would go back to the original, i.e., no compiler filtering. In any case, I want a better way to specify exactly what I want so that I don't have, say, intel creeping into my oneapi environment.

If that sounds good I can do either in this PR or in a separate one.

A separate PR is a good idea imo

@climbfuji
Copy link
Collaborator

#1618 was merged, please resolve the conflicts and mark this PR as ready/add reviewers and I will look at it. Thanks!

@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review April 30, 2025 17:58
@@ -2,6 +2,13 @@
# Portable way to get current directory
SPACK_STACK_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )

hostname=$(hostname)
case $hostname in
alogin*)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That hostname is very unfortunate. I can totally see other platforms using something like this, too ... but for now we don't have any other one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use hostname --fqdn. I'll be out the next couple days but I'll update this when I get the chance. With that it can be alogin*ncep.noaa.gov or something like that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add that when we need it - for now we're ok.

@climbfuji climbfuji enabled auto-merge (squash) May 1, 2025 17:49
@climbfuji climbfuji merged commit db20abd into JCSDA:develop May 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants