change to allow header and footer to be dynamic#2
Open
bsgriggs wants to merge 3 commits intoItvisors:mainfrom
Open
change to allow header and footer to be dynamic#2bsgriggs wants to merge 3 commits intoItvisors:mainfrom
bsgriggs wants to merge 3 commits intoItvisors:mainfrom
Conversation
Member
|
I'm a little worried about unexpected results when the expression takes slightly longer to resolve. By then, body content may heve been rendered causing layout issues. That was for me the main reason to only use a fixed enum property |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I'm not expecting a direct merge, but here is an example of allowing studio pro to dynamically allow a header and footer.
If you were to make this feature, I would recommend having an 'Header/Footer type' enum with