Skip to content

Emb ootb/master#824

Draft
lposen wants to merge 64 commits intorelease/2.3.0-betafrom
emb-ootb/master
Draft

Emb ootb/master#824
lposen wants to merge 64 commits intorelease/2.3.0-betafrom
emb-ootb/master

Conversation

@lposen
Copy link
Copy Markdown
Contributor

@lposen lposen commented Mar 13, 2026

🔹 JIRA Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

lposen and others added 30 commits October 13, 2025 16:38
…bedded-view-component

[MOB-12270] new-embedded-view-component
… loren/embedded/SDK-248-notification-component
@qltysh
Copy link
Copy Markdown

qltysh bot commented Mar 13, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on release/2.3.0-beta by 4.51%.

Modified Files with Diff Coverage (11)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
...edded/components/IterableEmbeddedCard/IterableEmbeddedCard.tsx100.0%
New file Coverage rating: A
...bleEmbeddedNotification/IterableEmbeddedNotification.styles.ts100.0%
New file Coverage rating: A
src/embedded/hooks/useEmbeddedView/getMedia.ts100.0%
New file Coverage rating: A
...components/IterableEmbeddedCard/IterableEmbeddedCard.styles.ts100.0%
New file Coverage rating: A
src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts100.0%
New file Coverage rating: A
...d/components/IterableEmbeddedBanner/IterableEmbeddedBanner.tsx100.0%
New file Coverage rating: A
src/embedded/components/IterableEmbeddedView.tsx100.0%
New file Coverage rating: A
src/embedded/constants/embeddedViewDefaults.ts100.0%
New file Coverage rating: A
src/embedded/hooks/useEmbeddedView/getStyles.ts100.0%
New file Coverage rating: A
.../IterableEmbeddedNotification/IterableEmbeddedNotification.tsx100.0%
New file Coverage rating: A
...onents/IterableEmbeddedBanner/IterableEmbeddedBanner.styles.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh
Copy link
Copy Markdown

qltysh bot commented Mar 13, 2026

16 new issues

Tool Category Rule Count
qlty Duplication Found 17 lines of similar code in 2 locations (mass = 66) 8
qlty Structure Function with high complexity (count = 9): Embedded 5
qlty Structure Function with many parameters (count = 4): getMedia 2
qlty Structure Function with many returns (count = 5): IterableEmbeddedView 1

Comment thread src/embedded/components/IterableEmbeddedBanner.tsx Outdated
Comment thread src/embedded/components/IterableEmbeddedCard.tsx Outdated
Comment thread src/embedded/components/IterableEmbeddedNotification.tsx Outdated
Comment thread src/embedded/components/IterableEmbeddedView.tsx Outdated
/** The type of view to render. */
viewType: IterableEmbeddedViewType,
/** The message to render. */
message: IterableEmbeddedMessage
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 4): getMedia [qlty:function-parameters]

Comment thread src/embedded/hooks/useEmbeddedView/getStyles.ts
Comment thread src/embedded/hooks/useEmbeddedView/getStyles.ts
Comment thread src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts
@lposen lposen changed the base branch from master to release/2.3.0-beta March 13, 2026 18:18
config,
onButtonClick = noop,
onMessageClick = noop,
}: IterableEmbeddedComponentProps
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 4): useEmbeddedView [qlty:function-parameters]

)}
</View>
</Pressable>
);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 7): IterableEmbeddedNotification [qlty:function-complexity]

}
}, [viewType]);

return Cmp ? <Cmp {...props} /> : null;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues:

1. Function with many returns (count = 5): IterableEmbeddedView [qlty:return-statements]


2. Function with high complexity (count = 5): IterableEmbeddedView [qlty:function-complexity]

Comment thread src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts
Comment thread src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts
Comment thread src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts
Comment thread src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts
Comment thread src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts
shadowOffset: { width: 0, height: 1 },
shadowOpacity: 0.9,
shadowRadius: 2,
width: '100%',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 17 lines of similar code in 2 locations (mass = 66) [qlty:similar-code]

]}
>
{message.elements?.body}
</Text>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 19 lines of similar code in 3 locations (mass = 65) [qlty:similar-code]

</TouchableOpacity>
);
})}
</View>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 31 lines of similar code in 3 locations (mass = 113) [qlty:similar-code]

)}
</View>
</Pressable>
);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 9): IterableEmbeddedBanner [qlty:function-complexity]

]}
>
{message.elements?.body}
</Text>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 19 lines of similar code in 3 locations (mass = 65) [qlty:similar-code]

</TouchableOpacity>
);
})}
</View>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 31 lines of similar code in 3 locations (mass = 113) [qlty:similar-code]

</View>
</View>
</Pressable>
);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 13): IterableEmbeddedCard [qlty:function-complexity]

shadowOffset: { width: 0, height: 1 },
shadowOpacity: 0.9,
shadowRadius: 2,
width: '100%',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 17 lines of similar code in 2 locations (mass = 66) [qlty:similar-code]

]}
>
{message.elements?.body}
</Text>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 19 lines of similar code in 3 locations (mass = 65) [qlty:similar-code]

</TouchableOpacity>
);
})}
</View>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 31 lines of similar code in 3 locations (mass = 113) [qlty:similar-code]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant