-
Notifications
You must be signed in to change notification settings - Fork 42
Loren/embedded/SDK-248-notification-component #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: loren/embedded/MOB-12270-new-embedded-view-component
Are you sure you want to change the base?
Loren/embedded/SDK-248-notification-component #814
Conversation
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Files with Diff Coverage (6)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
❌ 12 blocking issues (15 total)
|
| )} | ||
| </View> | ||
| </Pressable> | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /** The type of view to render. */ | ||
| viewType: IterableEmbeddedViewType, | ||
| /** The message to render. */ | ||
| message: IterableEmbeddedMessage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * @returns The styles. | ||
| * | ||
| * @example | ||
| * const styles = getStyles(IterableEmbeddedViewType.Notification, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * borderCornerRadius: 10, | ||
| * primaryBtnBackgroundColor: '#000000', | ||
| * primaryBtnTextColor: '#000000', | ||
| * }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * @returns The embedded view. | ||
| * | ||
| * @example | ||
| * const { handleButtonClick, handleMessageClick, media, parsedStyles } = useEmbeddedView(IterableEmbeddedViewType.Notification, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 3 issues:
1. tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag [eslint:tsdoc/syntax]
2. tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]
3. tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]
| * config, | ||
| * onButtonClick, | ||
| * onMessageClick, | ||
| * }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * | ||
| * return ( | ||
| * <View> | ||
| * <Text>{media.url}</Text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * return ( | ||
| * <View> | ||
| * <Text>{media.url}</Text> | ||
| * <Text>{media.caption}</Text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * <View> | ||
| * <Text>{media.url}</Text> | ||
| * <Text>{media.caption}</Text> | ||
| * <Text>{parsedStyles.backgroundColor}</Text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| config, | ||
| onButtonClick = () => {}, | ||
| onMessageClick = () => {}, | ||
| }: IterableEmbeddedComponentProps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

🔹 JIRA Ticket(s) if any
✏️ Description