Skip to content

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Feb 12, 2026

🔹 JIRA Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

@github-actions
Copy link

Lines Statements Branches Functions
Coverage: 61%
61.17% (427/698) 35.38% (109/308) 56.85% (141/248)

@qltysh
Copy link

qltysh bot commented Feb 12, 2026

Qlty

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on loren/embedded/MOB-12270-new-embedded-view-component by 1.38%.

Modified Files with Diff Coverage (6)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
...bleEmbeddedNotification/IterableEmbeddedNotification.styles.ts100.0%
New file Coverage rating: F
src/embedded/hooks/useEmbeddedView/getMedia.ts14.3%22-28
New file Coverage rating: F
src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts8.3%43-68
New file Coverage rating: A
src/embedded/hooks/useEmbeddedView/embeddedViewDefaults.ts100.0%
New file Coverage rating: F
src/embedded/hooks/useEmbeddedView/getStyles.ts28.6%20-26, 53
New file Coverage rating: F
.../IterableEmbeddedNotification/IterableEmbeddedNotification.tsx11.1%22-77
Total38.8%
🤖 Increase coverage with AI coding...

In the `loren/embedded/SDK-248-notification-component` branch, add test coverage for this new code:

- `src/embedded/components/IterableEmbeddedNotification/IterableEmbeddedNotification.tsx` -- Line 22-77
- `src/embedded/hooks/useEmbeddedView/getMedia.ts` -- Line 22-28
- `src/embedded/hooks/useEmbeddedView/getStyles.ts` -- Lines 20-26 and 53
- `src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts` -- Line 43-68

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh
Copy link

qltysh bot commented Feb 12, 2026

❌ 12 blocking issues (15 total)

Tool Category Rule Count
eslint Lint tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" 12
qlty Structure Function with many parameters (count = 4): getMedia 2
qlty Structure Function with high complexity (count = 7): IterableEmbeddedNotification 1

)}
</View>
</Pressable>
);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 7): IterableEmbeddedNotification [qlty:function-complexity]

/** The type of view to render. */
viewType: IterableEmbeddedViewType,
/** The message to render. */
message: IterableEmbeddedMessage
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 4): getMedia [qlty:function-parameters]

* @returns The styles.
*
* @example
* const styles = getStyles(IterableEmbeddedViewType.Notification, {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]

* borderCornerRadius: 10,
* primaryBtnBackgroundColor: '#000000',
* primaryBtnTextColor: '#000000',
* });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag [eslint:tsdoc/syntax]

* @returns The embedded view.
*
* @example
* const { handleButtonClick, handleMessageClick, media, parsedStyles } = useEmbeddedView(IterableEmbeddedViewType.Notification, {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 3 issues:

1. tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag [eslint:tsdoc/syntax]


2. tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]


3. tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]

* config,
* onButtonClick,
* onMessageClick,
* });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag [eslint:tsdoc/syntax]

*
* return (
* <View>
* <Text>{media.url}</Text>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues:

1. tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag [eslint:tsdoc/syntax]


2. tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]

* return (
* <View>
* <Text>{media.url}</Text>
* <Text>{media.caption}</Text>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues:

1. tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag [eslint:tsdoc/syntax]


2. tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]

* <View>
* <Text>{media.url}</Text>
* <Text>{media.caption}</Text>
* <Text>{parsedStyles.backgroundColor}</Text>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues:

1. tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag [eslint:tsdoc/syntax]


2. tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]

config,
onButtonClick = () => {},
onMessageClick = () => {},
}: IterableEmbeddedComponentProps
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 4): useEmbeddedView [qlty:function-parameters]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant