[MOB-12231] refactor-classes-to-reduce-circular-dependencies #731
Conversation
…SDK initialization and logging
…ions and usage examples
6 new issues
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
…lure' into MOB-12231-refactor-classes-to-reduce-circular-dependencies
…lure' into MOB-12231-refactor-classes-to-reduce-circular-dependencies
…rectly in relevant classes
|
|
Diff Coverage: The code coverage on the diff in this pull request is 82.4%. Total Coverage: This PR will increase coverage by 3.98%. File Coverage Changes
🛟 Help
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
| "prepare": "yarn build", | ||
| "release": "release-it" | ||
| "release": "release-it", | ||
| "circ": "npx madge --circular --extensions ts ./" |
There was a problem hiding this comment.
Is it a dedicated package to results circular dependency?
src/core/classes/Iterable.ts
Outdated
| import type { IterableCommerceItem } from './IterableCommerceItem'; | ||
| import { IterableConfig } from './IterableConfig'; | ||
| import { IterableLogger } from './IterableLogger'; | ||
| import type { IterableAuthFailure } from '../types/IterableAuthFailure'; |
There was a problem hiding this comment.
Import 'type' is removed above. Is this one ok?
There was a problem hiding this comment.
Yes. The issue was coming from the use of Iterable.logger in IterableInAppManager. This has been changed to not require that anymore.
src/core/classes/Iterable.ts
Outdated
|
|
||
| const RNEventEmitter = new NativeEventEmitter(RNIterableAPI); | ||
|
|
||
| const defaultConfig = new IterableConfig(); |
There was a problem hiding this comment.
Not sure how default implementation comes into play. Any possibility of regression?
There was a problem hiding this comment.
No -- it's the same functionality as was there before -- it's just assigning it to a variable
…gging behavior and hierarchy
…sses' into jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br
…oid-br' into MOB-12231-refactor-classes-to-reduce-circular-dependencies
…thManager from Iterable class
| static initialize2WithApiKey( | ||
| apiKey: string, | ||
| config: IterableConfig = new IterableConfig(), | ||
| version: string, | ||
| apiEndPoint: string |
| static trackPushOpenWithCampaignId( | ||
| campaignId: number, | ||
| templateId: number, | ||
| messageId: string | null | undefined, | ||
| appAlreadyRunning: boolean, | ||
| dataFields?: unknown |
| static trackInAppClose( | ||
| message: IterableInAppMessage, | ||
| location: IterableInAppLocation, | ||
| source: IterableInAppCloseSource, | ||
| clickedUrl?: string |
| static updateSubscriptions( | ||
| emailListIds: number[] | null, | ||
| unsubscribedChannelIds: number[] | null, | ||
| unsubscribedMessageTypeIds: number[] | null, | ||
| subscribedMessageTypeIds: number[] | null, | ||
| campaignId: number, | ||
| templateId: number |
2 participants
🔹 JIRA Ticket(s) if any
✏️ Description