-
Notifications
You must be signed in to change notification settings - Fork 39
Loren/embedded/all #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lposen
wants to merge
48
commits into
MOB-12231-refactor-classes-to-reduce-circular-dependencies
Choose a base branch
from
loren/embedded/all
base: MOB-12231-refactor-classes-to-reduce-circular-dependencies
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Loren/embedded/all #730
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
85e28d7
feat: introduce IterableAuthManager for authentication handling
lposen 86d9b41
refactor: initialize defaults for logger, config, authManager, and in…
lposen 6b84340
fix: enhance error handling and logging for JWT authentication failures
lposen 4b40861
feat: implement IterableTracking and session management for embedded …
lposen 26ddabd
feat: implement IterableApi class for enhanced tracking and user mana…
lposen f2aa18d
Merge branch 'jwt/authManager' into loren/embedded/all
lposen 2f19aef
refactor: update Iterable classes to use static logger
lposen 7aef30a
refactor: replace RNIterableAPI calls with IterableApi methods
lposen 8e781df
Merge branch 'MOB-12231-refactor-classes-to-reduce-circular-dependenc…
lposen 0adbc44
feat: introduce tracking manager in Iterable class and refactor track…
lposen e04f41f
feat: implement embedded messaging functionality with new classes and…
lposen 2106df0
feat: add getEmbeddedMessages method to IterableApi for retrieving em…
lposen 09f371e
feat: add support for enabling embedded messaging and update Iterable…
lposen 1846e74
feat: implement IterableEmbeddedView and related types for embedded m…
lposen 1408854
feat: enhance IterableApi with new tracking methods for embedded sess…
lposen 452444a
feat: update Iterable class tracker with new embedded tracking methods
lposen a6a45ed
feat: implement getEmbeddedMessages method and enhance serialization …
lposen d67c1ed
feat: add getEmbeddedMessages method to RNIterableAPIModule for embed…
lposen a4fe2ac
fix: update enableEmbeddedMessaging configuration to use configReadab…
lposen bae7dbf
feat: update getEmbeddedMessages method to accept multiple placement IDs
lposen ec940a9
feat: synchronize embedded messages on initialization
lposen b24ca2e
feat: add syncEmbeddedMessages and getEmbeddedPlacementIds
lposen 33a9498
feat: add embedded update listener support to RNIterableAPIModule and…
lposen f31dd72
feat: add start and end session methods for embedded messaging
lposen 76a1ca3
feat: add start and pause impression methods for embedded messaging
lposen 1e349df
feat: add handleEmbeddedClick and trackEmbeddedClick methods
lposen 0e53674
fix: import missing IterableEmbeddedMessage
lposen 3466661
refactor: giving up on the callbacks
lposen 95b8085
refactor: remove embedded update listener methods from RNIterableAPIM…
lposen 7421938
feat: add Embedded component and integrate into navigation
lposen 595560c
feat: enhance Embedded component with new styles and message handling
lposen 22fa618
feat: initial implementation of IterableEmbeddedBanner and IterableEm…
lposen 371fad9
feat: added buttons to banner
lposen e6c1132
feat: enhance IterableEmbedded components with button click handling …
lposen 14922e0
feat: fix error on embedded button click
lposen 297ae51
feat: improve Embedded component with enhanced message fetching and s…
lposen 13fc4a5
feat: implemented IterableEmbeddedNotification
lposen 56d8dfc
feat: initial card view
lposen f9b22b7
feat: completed styles for IterableEmbeddedCard
lposen 383e308
feat: refactor embedded click handling and introduce action prefix ut…
lposen 1115268
feat: refactor IterableEmbedded components to utilize useEmbeddedView…
lposen 4732925
feat: add visibility tracking and refactor image dimensions in Iterab…
lposen 8149ed0
feat: request notification permission for Android 13+ in App component
lposen 0ce8ecb
refactor: trying to get session start and end to work
lposen e0c27e0
refactor: reorganize IterableEmbedded types and interfaces for better…
lposen 24e55d1
feat: consolidate other hooks into the usembedded hook
lposen 0b147e8
feat: add TODOs for tracking session and impression events in Iterabl…
lposen 4b71391
Merge branch 'MOB-12231-refactor-classes-to-reduce-circular-dependenc…
lposen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Embedded | ||
|
||
## TODO | ||
- [ ] Track session start and stop | ||
- [ ] Track pause and start impression | ||
- [ ] Align styles with OOTB view notes | ||
- https://support.iterable.com/hc/en-us/articles/23230946708244-Out-of-the-Box-Views-for-Embedded-Messages | ||
- [ ] Go through [Evans | ||
google doc](https://docs.google.com/document/d/15GNyo2x5QwYBPUliB4JZvXLkb04ZkW96jcbUJ96YrAM/edit?tab=t.0) | ||
and [Slab doc](https://iterable.slab.com/posts/embedded-messaging-rn-sdk-urwffrhx#h8if0-public-methods) | ||
and see if there is anything else to do | ||
- [ ] Add the ability to switch between views in the example app. And the | ||
ability to configure your own JSON. | ||
|
||
|
||
## Resources | ||
- [RN SDK - In-app review](https://iterable.slab.com/posts/rn-sdk-in-app-review-bl2vp1ds) | ||
- [Google doc](https://docs.google.com/document/d/15GNyo2x5QwYBPUliB4JZvXLkb04ZkW96jcbUJ96YrAM/edit?tab=t.0) | ||
- [Embedded Messaging - RN SDK](https://iterable.slab.com/posts/embedded-messaging-rn-sdk-urwffrhx#h8if0-public-methods) | ||
- [New arch customers](https://docs.google.com/spreadsheets/d/1FzoAH5CAcNy92Km5DLqr8yYvPDBPLTuBXa0_CXZEUCA/edit?gid=60700846#gid=60700846) | ||
- [RN Epic](https://iterable.atlassian.net/browse/MOB-7052) | ||
- [Figma](https://www.figma.com/design/rbDozNjEF9MjwbvSqzrVTv/Flex-Messaging?node-id=3804-186809&p=f) | ||
- [Embedded Messaging: Timeline for a Successful GA Release](https://iterable.slab.com/posts/embedded-messaging-timeline-for-a-successful-ga-release-7f762g1c) | ||
- [Embedded Task Prioritization](https://tables.area120.google.com/u/0/workspace/av3wJDN6_I94tIbdapKOzu/table/9jRcY5gDv2OaTnkceKbOA5) | ||
- [Acceptance Criteria](https://iterable.slab.com/posts/embedded-messaging-acceptance-criteria-80gfn857) | ||
- [Bug Bash Test Cases](https://docs.google.com/spreadsheets/d/1ZrM8vMoMjhK4x18uoqtcOyUqDhFqlwTfrUWAM7csibQ/edit?gid=1805677430#gid=1805677430) | ||
- [Stories for original](https://docs.google.com/spreadsheets/d/1ZrM8vMoMjhK4x18uoqtcOyUqDhFqlwTfrUWAM7csibQ/edit?gid=1805677430#gid=1805677430) | ||
- [Datadog story](https://iterable.atlassian.net/browse/MOB-6926) | ||
- [Yellow Brick Road: Embedded Messaging Mobile SDK](https://iterable.slab.com/posts/yellow-brick-road-embedded-messaging-mobile-sdk-4v032ww9?shr=4v032ww9#h69qk-2024-01-19-ootb-style-layout-conversation) | ||
- [Android SDK Embedded OOTB Constraint | ||
finalization](https://iterable.atlassian.net/browse/MOB-7678) | ||
- [iOS SDK Embedded OOTB Constraint finalization](https://iterable.atlassian.net/browse/MOB-7679) | ||
- [OOTB view bugs review](https://iterable.slab.com/posts/ootb-view-bugs-review-7u978hhy?shr=7u978hhy) | ||
- [Non-RN Embedded Epic](https://iterable.atlassian.net/browse/MOB-5235) | ||
- [OOTB Style/Layout Questions](https://iterable.atlassian.net/browse/MOB-5235) | ||
- [Evan PR](https://github.com/Iterable/react-native-sdk/pull/732) | ||
- [My PR](https://github.com/Iterable/react-native-sdk/pull/730) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.