[MOB-10290] create-loader-for-rniterableapi#612
Merged
lposen merged 4 commits into2.0.0-alpha/masterfrom Jan 6, 2025
Merged
Conversation
|
…OB-10290-create-loader-for-rniterableapi
…OB-10290-create-loader-for-rniterableapi
evantk91
approved these changes
Dec 18, 2024
Contributor
evantk91
left a comment
evantk91
left a comment
There was a problem hiding this comment.
Looks great! nice reorganization.
| // TODO: Create a loader for this | ||
| const RNIterableAPI = NativeModules.RNIterableAPI; | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Nice this makes it much cleaner and maintainable
Base automatically changed from
2.0.0-alpha/MOB-10208-fix-npmignore
to
2.0.0-alpha/master
January 6, 2025 19:52
lposen
deleted the
2.0.0-alpha/MOB-10290-create-loader-for-rniterableapi
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description
Creates a loader for
RNIterableAPIso that there is consistent error messaging when it is an issue.